From 420879f650d16414134d581cc0f09e196b3f36cb Mon Sep 17 00:00:00 2001 From: Eric Davis Date: Fri, 29 Jan 2010 15:44:33 -0800 Subject: [PATCH] Refactor: Removed an iterator by using Enumerable's partition method --- app/helpers/bulk_time_entries_helper.rb | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/app/helpers/bulk_time_entries_helper.rb b/app/helpers/bulk_time_entries_helper.rb index 16e6991..bae0a54 100644 --- a/app/helpers/bulk_time_entries_helper.rb +++ b/app/helpers/bulk_time_entries_helper.rb @@ -11,15 +11,7 @@ def label_for_field(field, rnd_id, options = { }) end def grouped_options_for_issues(issues) - open_issues = [] - closed_issues = [] - issues.each do |issue| - if issue.closed? - closed_issues << issue - else - open_issues << issue - end - end + closed_issues, open_issues = *issues.partition {|issue| issue.closed?} html = '' unless open_issues.empty?