Refactor: Extract Method

Extracted duplicated code into a utility method.
edavis10 · Jan 29, 2010 · 9de6913 · 9de6913
1 parent 894c173
commit 9de6913
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/app/helpers/bulk_time_entries_helper.rb b/app/helpers/bulk_time_entries_helper.rb
@@ -23,16 +23,19 @@ def grouped_options_for_issues(issues)
 
     html = '<option></option>'
     unless open_issues.empty?
-      html << "<optgroup label='#{l(:label_open_issues)}'>"
-      html << options_from_collection_for_select(open_issues, :id, :to_s)
-      html << "</optgroup>"
+      html << labeled_option_group_from_collection_for_select(:label_open_issues, open_issues)
     end
 
     unless closed_issues.empty?
-      html << "<optgroup label='#{l(:label_closed_issues)}'>"
-      html << options_from_collection_for_select(closed_issues, :id, :to_s)
-      html << "</optgroup>"
+      html << labeled_option_group_from_collection_for_select(:label_closed_issues, closed_issues)
     end
     html
   end
+
+  def labeled_option_group_from_collection_for_select(label, collection)
+    html = "<optgroup label='#{l(label)}'>"
+    html << options_from_collection_for_select(collection, :id, :to_s)
+    html << "</optgroup>"
+    html
+  end
 end