Refactor: Extract method to create a Change from a Changeset.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3360 e93f8b46-1217-0410-a6f0-8f06a7374b81
edavis10 · Feb 2, 2010 · 39c5857 · splattael · Feb 2, 2010 · 39c5857
1 parent 358e319
commit 39c5857
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 15 deletions.
diff --git a/app/models/changeset.rb b/app/models/changeset.rb
@@ -148,6 +148,15 @@ def next
   def self.normalize_comments(str)
     to_utf8(str.to_s.strip)
   end
+
+  # Creates a new Change from it's common parameters
+  def create_change(change)
+    Change.create(:changeset => self,
+                  :action => change[:action],
+                  :path => change[:path],
+                  :from_path => change[:from_path],
+                  :from_revision => change[:from_revision])
+  end
 
   private
 

diff --git a/app/models/repository/darcs.rb b/app/models/repository/darcs.rb
@@ -85,11 +85,7 @@ def fetch_changesets
                                          :comments => revision.message)
 
             revision.paths.each do |change|
-              Change.create(:changeset => changeset,
-                            :action => change[:action],
-                            :path => change[:path],
-                            :from_path => change[:from_path],
-                            :from_revision => change[:from_revision])
+              changeset.create_change(change)
             end
             next_rev += 1
           end if revisions

diff --git a/app/models/repository/mercurial.rb b/app/models/repository/mercurial.rb
@@ -78,11 +78,7 @@ def fetch_changesets
                                            :comments => revision.message)
 
               revision.paths.each do |change|
-                Change.create(:changeset => changeset,
-                              :action => change[:action],
-                              :path => change[:path],
-                              :from_path => change[:from_path],
-                              :from_revision => change[:from_revision])
+                changeset.create_change(change)
               end
             end
           end unless revisions.nil?

diff --git a/app/models/repository/subversion.rb b/app/models/repository/subversion.rb
@@ -63,11 +63,7 @@ def fetch_changesets
                                            :comments => revision.message)
 
               revision.paths.each do |change|
-                Change.create(:changeset => changeset,
-                              :action => change[:action],
-                              :path => change[:path],
-                              :from_path => change[:from_path],
-                              :from_revision => change[:from_revision])
+                changeset.create_change(change)
               end unless changeset.new_record?
             end
           end unless revisions.nil?