From 990a48de2304d16a29ed2f48b5aac28b548f8b57 Mon Sep 17 00:00:00 2001 From: Eric Davis Date: Thu, 1 Apr 2010 08:35:24 -0700 Subject: [PATCH] Refactor: Extract method from Kanban#get_active and #get_testing. --- app/models/kanban.rb | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/app/models/kanban.rb b/app/models/kanban.rb index 8a9468c..cfbe846 100644 --- a/app/models/kanban.rb +++ b/app/models/kanban.rb @@ -95,19 +95,11 @@ def get_users end def get_active - active = {} - @users.each do |user| - active[user] = KanbanIssue.find_active(user.id) - end unless @users.blank? - active + issues_from_kanban_issue(:active) end def get_testing - testing = {} - @users.each do |user| - testing[user] = KanbanIssue.find_testing(user.id) - end unless @users.blank? - testing + issues_from_kanban_issue(:testing) end def quick_issue_ids @@ -223,4 +215,15 @@ def get_issues_for_pane(pane) return issues.group_by(&:assigned_to) end + + def issues_from_kanban_issue(pane) + return {} unless [:active, :testing].include?(pane) + + issues = {} + @users.each do |user| + issues[user] = KanbanIssue.send('find_' + pane.to_s, user.id) + end unless @users.blank? + issues + + end end