From d484376ce72831db36050371c0dc609737f0bdfa Mon Sep 17 00:00:00 2001 From: Robert Muir Date: Fri, 25 Sep 2015 23:32:52 -0400 Subject: [PATCH] Don't let ubuntu try to install its crazy jayatana agent. By default, our security stuff will reject this (as do other apps). See https://bugs.launchpad.net/ubuntu/+source/jayatana/+bug/1441487 However its not really the user's fault, ubuntu screws up here by installing this agent by default. We don't want any agents. So instead, we drop it like this: ``` $ bin/elasticsearch Warning: Ignoring JAVA_TOOL_OPTIONS=-Bogus1 -Bogus2 Please pass JVM parameters via JAVA_OPTS instead [2015-09-25 23:34:39,777][INFO ][node ] [Doctor Bong] version[3.0.0-SNAPSHOT], pid[19044], build[2f5b6ea/2015-09-26T03:18:16Z] ... ``` Closes #13785 --- distribution/src/main/resources/bin/elasticsearch | 8 ++++++++ distribution/src/main/resources/bin/plugin | 7 +++++++ 2 files changed, 15 insertions(+) diff --git a/distribution/src/main/resources/bin/elasticsearch b/distribution/src/main/resources/bin/elasticsearch index 88639c502b45a..878fcff3929f4 100755 --- a/distribution/src/main/resources/bin/elasticsearch +++ b/distribution/src/main/resources/bin/elasticsearch @@ -113,6 +113,14 @@ if [ -z "$ES_CLASSPATH" ]; then exit 1 fi +# don't let JAVA_TOOL_OPTIONS slip in (e.g. crazy agents in ubuntu) +# works around https://bugs.launchpad.net/ubuntu/+source/jayatana/+bug/1441487 +if [ "x$JAVA_TOOL_OPTIONS" != "x" ]; then + echo "Warning: Ignoring JAVA_TOOL_OPTIONS=$JAVA_TOOL_OPTIONS" + echo "Please pass JVM parameters via JAVA_OPTS instead" + unset JAVA_TOOL_OPTIONS +fi + # Special-case path variables. case `uname` in CYGWIN*) diff --git a/distribution/src/main/resources/bin/plugin b/distribution/src/main/resources/bin/plugin index 0eef371c2da5e..c466d483e38f4 100755 --- a/distribution/src/main/resources/bin/plugin +++ b/distribution/src/main/resources/bin/plugin @@ -59,6 +59,13 @@ if [ -n "$ES_ENV_FILE" ]; then fi fi +# don't let JAVA_TOOL_OPTIONS slip in (e.g. crazy agents in ubuntu) +# works around https://bugs.launchpad.net/ubuntu/+source/jayatana/+bug/1441487 +if [ "x$JAVA_TOOL_OPTIONS" != "x" ]; then + echo "Warning: Ignoring JAVA_TOOL_OPTIONS=$JAVA_TOOL_OPTIONS" + unset JAVA_TOOL_OPTIONS +fi + if [ -x "$JAVA_HOME/bin/java" ]; then JAVA=$JAVA_HOME/bin/java else