Fix handling of IndicesOptions in update settings REST API #10030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Update Settings API tries to merge the query params with the settings sent as body and excluding some "well known params" such as pretty, timeouts ...
Those well known params does not include the params used by IndicesOptions, so ES merges those params with the settings but the resulting settings are invalid.
e.g.
returns
but works correctly without params relate to IndicesOptions.
I did not look at other APIs but some may suffer from the same issue.