New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translog: stats fail to serialize size #10105
Conversation
} | ||
|
||
@Override | ||
public void writeTo(StreamOutput out) throws IOException { | ||
out.writeVInt(estimatedNumberOfOperations); | ||
if (out.getVersion().onOrAfter(Version.V_1_5_0)) { | ||
out.writeLong(translogSizeInBytes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use readVLong
/writeVLong
, or can this be negative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My rational is that this is not a high performance API, so I tend not to use writeVLong because of it's limitation regarding negative numbers. Will change though, as here it's possible.
left some comment |
@bleskes do you think it'd be worth adding a backwards compatibility test for translog stats in general? |
LGTM |
@bleskes works for me, LGTM too! |
No description provided.