Remove duplicated consistency level and replication type setters #10188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tters `setConsistencyLevel` and `setReplicationType` are already present in the base class `ShardReplicationOperationRequestBuilder`. They are not needed in `DeleteRequestBuilder` and `IndexRequestBuilder`.
javanna
added
>enhancement
v2.0.0-beta1
review
:Core/Infra/Transport API
|
this is 1.6 only I removed those all in 2.0 already |
|
@s1monw async replication has been removed from master, write consistency is still there: https://github.com/elastic/elasticsearch/blob/master/src/main/java/org/elasticsearch/action/index/IndexRequestBuilder.java#L259 . That is why this PR is against 1.x, when cherry-picking to master I will take care of conflicts. |
|
kk |
|
LGTM |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setConsistencyLevelandsetReplicationTypeare already present in the base classShardReplicationOperationRequestBuilder. They are not needed inDeleteRequestBuilderandIndexRequestBuilder.