Schedule transport ping interval #10189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimchy
added
v2.0.0-beta1
review
:Distributed/Network
| if (lifecycle.stoppedOrClosed()) { | ||
| return; | ||
| } | ||
| for (Map.Entry<DiscoveryNode, NodeChannels> entry : connectedNodes.entrySet()) { |
There was a problem hiding this comment.
can you assign the key and the value here before we use it? it's way easier to read
|
I left some comments |
|
@s1monw addressed your comments, ready for another round |
| DiscoveryNode node = entry.getKey(); | ||
| NodeChannels channels = entry.getValue(); | ||
| // we only support the ping message format since 1.6 | ||
| if (node.version().onOrAfter(Version.V_1_6_0)) { |
There was a problem hiding this comment.
please make sure you remove the conditional on master
|
left one comment LGTM otherwise |
Sometimes, when using transport client for example, through a load balancer, there is a need to send a scheduled ping message to keep each channel alive. Add support for `transport.ping_schedule`, which controls the schedule (-1 for disabled) at which a ping message will be sent. For transport client case, it gets enabled automatically since almost always this is the desired behavior. We use the same 6 bytes header format for the ping message, with ES header and -1 for data length for ping message, and simply continue to process the next messages once this is encountered. closes elastic#10189
kimchy
added a commit
that referenced
this pull request
Mar 21, 2015
Sometimes, when using transport client for example, through a load balancer, there is a need to send a scheduled ping message to keep each channel alive. Add support for `transport.ping_schedule`, which controls the schedule (-1 for disabled) at which a ping message will be sent. For transport client case, it gets enabled automatically since almost always this is the desired behavior. We use the same 6 bytes header format for the ping message, with ES header and -1 for data length for ping message, and simply continue to process the next messages once this is encountered. closes #10189
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, when using transport client for example, through a load balancer, there is a need to send a scheduled ping message to keep each channel alive.
Add support for
transport.ping_schedule, which controls the schedule (-1 for disabled) at which a ping message will be sent. For transport client case, it gets enabled automatically since almost always this is the desired behavior.We use the same 6 bytes header format for the ping message, with ES header and -1 for data length for ping message, and simply continue to process the next messages once this is encountered.