Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node id to _cat/shards #10226

Closed
lmenezes opened this issue Mar 23, 2015 · 4 comments
Closed

add node id to _cat/shards #10226

lmenezes opened this issue Mar 23, 2015 · 4 comments
Assignees
Labels

Comments

@lmenezes
Copy link
Contributor

would be nice having node id in here. Even though having nodes with the same name and ip is not a likely scenario, it's still possible.

if this sounds reasonable, I would be more than happy to send a PR.

@javanna
Copy link
Member

javanna commented Mar 24, 2015

Makes sense to me, what do you think @drewr ?

@drewr
Copy link
Contributor

drewr commented Mar 24, 2015

Agree, we should have node name and id on all APIs.

@lmenezes
Copy link
Contributor Author

Will you take care of it, or should I send a PR?

@drewr
Copy link
Contributor

drewr commented Mar 24, 2015

@lmenezes Happy to have a PR!

@javanna javanna self-assigned this Mar 25, 2015
javanna pushed a commit to javanna/elasticsearch that referenced this issue Mar 25, 2015
javanna pushed a commit to javanna/elasticsearch that referenced this issue Mar 25, 2015
javanna pushed a commit to javanna/elasticsearch that referenced this issue Mar 25, 2015
javanna pushed a commit to javanna/elasticsearch that referenced this issue Mar 25, 2015
javanna pushed a commit to javanna/elasticsearch that referenced this issue Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants