Fix wrong use of currentFieldName outside of a parsing loop #10307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing a multipercolate request copies the content of the JSON to a Map and then iterates on the entrySet, but for the fields
ignore_unavailable
,allow_no_indices
andexpand_wildcards
it is still using the currentFieldName variable and not entry.getKey().This cause the parsing to fail if the last fieldName of the JSON was one of these fields.
example :
will fail with error :
This PR fixes the parsing and also extracts the parsing to a map to a dedicated method to avoid having the parsing vars wrongly reused in the future.