Make sure size=0 works on the inner_hits level. #10388
Merged
+62
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return topDocsCollector.topDocs(from(), size()); | ||
|
|
||
| int topN = from() + size(); | ||
| if (topN == 0) { |
There was a problem hiding this comment.
I think you should just check size() == 0? If from is 3 and size 0, we still only need to count matches?
There was a problem hiding this comment.
good point, I'll change that
|
Left one minor comment, otherwise LGTM. Feel free to push without further review! |
martijnvg
force-pushed
the
inner_hits/size_0
branch
from
c535e07
to
e390ef5
Compare
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #10358