New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove groovy sandbox #10480
Remove groovy sandbox #10480
Conversation
@dakrone can you have a look please? |
@javanna there are still a lot of references to the sandbox in Code-wise this looks good to me |
@dakrone I left those references on purpose at the beginning of the file, I thought we wanted to have the security alert on all branches. It mentions explicitly the versions that are vulnerable that require to turn off the sandbox. @clintongormley shall we remove this part from the scripting docs on master? |
@javanna I'd remove that section from the scripting page and add a note to the migration page. |
@clintongormley I left the dyanmic scripts note aat the beginning of the page, but removed references to groovy sandbox and settings. I had already added a note to the migration page, is that not enough? |
LGTM |
Due to elastic/elasticsearch#10480 Closes #100.
We should have checked and failed if there is an inconsistent pair of data node plan and target indices. This PR strengthens these checks and adds assertions to fail hard in tests. Relates #10480
We should have checked and failed if there is an inconsistent pair of data node plan and target indices. This PR strengthens these checks and adds assertions to fail hard in tests. Relates elastic#10480
We should have checked and failed if there is an inconsistent pair of data node plan and target indices. This PR strengthens these checks and adds assertions to fail hard in tests. Relates elastic#10480
We should have checked and failed if there is an inconsistent pair of data node plan and target indices. This PR strengthens these checks and adds assertions to fail hard in tests. Relates elastic#10480
Closes #10156