Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove groovy sandbox #10480

Closed

Conversation

javanna
Copy link
Member

@javanna javanna commented Apr 8, 2015

Closes #10156

@javanna javanna added >enhancement v2.0.0-beta1 review :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache labels Apr 8, 2015
@javanna
Copy link
Member Author

javanna commented Apr 8, 2015

@dakrone can you have a look please?

@dakrone
Copy link
Member

dakrone commented Apr 8, 2015

@javanna there are still a lot of references to the sandbox in docs/reference/modules/scripting.asciidoc (near the beginning of the file)

Code-wise this looks good to me

@javanna
Copy link
Member Author

javanna commented Apr 9, 2015

there are still a lot of references to the sandbox in docs/reference/modules/scripting.asciidoc (near the beginning of the file)

@dakrone I left those references on purpose at the beginning of the file, I thought we wanted to have the security alert on all branches. It mentions explicitly the versions that are vulnerable that require to turn off the sandbox.

@clintongormley shall we remove this part from the scripting docs on master?

@clintongormley
Copy link

@javanna I'd remove that section from the scripting page and add a note to the migration page.

@javanna
Copy link
Member Author

javanna commented Apr 16, 2015

@clintongormley I left the dyanmic scripts note aat the beginning of the page, but removed references to groovy sandbox and settings. I had already added a note to the migration page, is that not enough?

@clintongormley
Copy link

LGTM

@javanna javanna closed this in c914134 Apr 28, 2015
@kevinkluge kevinkluge removed the review label Apr 28, 2015
dadoonet added a commit to elastic/elasticsearch-river-couchdb that referenced this pull request Apr 29, 2015
@clintongormley clintongormley changed the title Scripting: remove groovy sandbox Remove groovy sandbox Jun 7, 2015
dnhatn added a commit that referenced this pull request Feb 1, 2024
We should have checked and failed if there is an inconsistent pair of 
data node plan and target indices. This PR strengthens these checks and
adds assertions to fail hard in tests.

Relates #10480
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 1, 2024
We should have checked and failed if there is an inconsistent pair of
data node plan and target indices. This PR strengthens these checks and
adds assertions to fail hard in tests.

Relates elastic#10480
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 1, 2024
We should have checked and failed if there is an inconsistent pair of
data node plan and target indices. This PR strengthens these checks and
adds assertions to fail hard in tests.

Relates elastic#10480
elasticsearchmachine pushed a commit that referenced this pull request Feb 1, 2024
We should have checked and failed if there is an inconsistent pair of
data node plan and target indices. This PR strengthens these checks and
adds assertions to fail hard in tests.

Relates #10480
jedrazb pushed a commit to jedrazb/elasticsearch that referenced this pull request Feb 2, 2024
We should have checked and failed if there is an inconsistent pair of 
data node plan and target indices. This PR strengthens these checks and
adds assertions to fail hard in tests.

Relates elastic#10480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What should we do with groovy sandboxing?
4 participants