Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync translog before closing engine #10484

Merged
merged 1 commit into from Apr 8, 2015

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Apr 8, 2015

If the translog is buffered we must make sure everything is synced to disk
before we rollback the writer otherwise we open a window for potential dataloss due
to stupid errors preventing the translog from being closed.

@s1monw
Copy link
Contributor Author

s1monw commented Apr 8, 2015

@bleskes can you take a look?

@bleskes
Copy link
Contributor

bleskes commented Apr 8, 2015

LGTM. Can we change the title to sync translog when closing engine?

Also, to be clear - on normal shutdown we flush so this is mostly relevant to closing an index right?

@s1monw s1monw changed the title [ENGINE] flush translog before closing engine [ENGINE] sync translog before closing engine Apr 8, 2015
If the translog is buffered we must make sure everything is synced to disk
before we rollback the writer otherwise we open a window for potential dataloss due
to stupid errors preventing the translog from being closed.
@s1monw s1monw force-pushed the flush_translog_on_engine_close branch from 7936442 to f687377 Compare April 8, 2015 15:57
@s1monw s1monw merged commit f687377 into elastic:master Apr 8, 2015
@s1monw s1monw deleted the flush_translog_on_engine_close branch April 8, 2015 16:00
@clintongormley clintongormley changed the title [ENGINE] sync translog before closing engine Sync translog before closing engine May 29, 2015
@clintongormley clintongormley added :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. and removed :Engine :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. resiliency v1.5.1 v1.6.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants