Added short comment on snapshotting closed indices #10579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppf2
added
>docs
|
I think it should be "If the |
|
I might be missing something but I think we can also improve on the error message in this case? If the error message was clear like "can't snapshot closed indices" ,we could just say that only open yellow indices can be snapshotted. @imotov , what do you think? |
|
+1 on @bleskes 's idea on improving the reason message |
To include Java 8 and recommendation to install the same version of Java to all nodes in the cluster.
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Apr 15, 2015
Currently the error message is the same when index is closed and when it is missing shards. This commit will generate a specific failure message when a user tries to create a snapshot of a closed index. Related to elastic#10579
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Apr 20, 2015
Currently the error message is the same when index is closed and when it is missing shards. This commit will generate a specific failure message when a user tries to create a snapshot of a closed index. Related to elastic#10579
imotov
added a commit
that referenced
this pull request
Apr 20, 2015
Currently the error message is the same when index is closed and when it is missing shards. This commit will generate a specific failure message when a user tries to create a snapshot of a closed index. Related to #10579
|
Hi @ppf2 It looks like you've mixed two different changes into this PR: one for Java versions and one for snapshot/restore. The latter is no longer accurate since #10608 was pushed. I'm going to close this PR - please feel free to open a new one with just the Java changes (or just push those changes directly) thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying again, didn't pick up changed file last time.