Don't use bitset cache for children filters. #10663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (filter == null) { | ||
| continue; | ||
| } | ||
| DocIdSet nestedTypeSet = filter.getDocIdSet(context, context.reader().getLiveDocs()); |
There was a problem hiding this comment.
Do we really need to pass livedocs?
There was a problem hiding this comment.
it just felt safe to do this... but I don't we need to, because nested docs can't be modified on their own. Their life cycle depends on the parent doc.
There was a problem hiding this comment.
I think its a little confusing, since we explicitly didn't pass bits before. IMO we should just have a code comment
There was a problem hiding this comment.
I added a comment regarding this.
| } | ||
| // We can pass down 'null' as acceptedDocs, because nestedDocId is a doc to be fetched and | ||
| // therefor is guaranteed to be a live doc. | ||
| DocIdSet nestedTypeSet = filter.getDocIdSet(context, null); |
There was a problem hiding this comment.
Filter.getDocIdSet can return null, can you check that nestedTypeSet is not null?
|
LGTM |
|
I just left a comment about some missing null checks. |
martijnvg
force-pushed
the
inner_hits/use_bitset_cache_only_for_parent_filters
branch
from
3687d9b
to
0ad1c12
Compare
Only parent filters should use bitset filter cache, to avoid memory being wasted. Also in case of object fields inline the field name into the nested object, instead of creating an additional (dummy) nested identity. Closes elastic#10662 Closes elastic#10629
martijnvg
force-pushed
the
inner_hits/use_bitset_cache_only_for_parent_filters
branch
from
79ca16d
to
7a6fe80
Compare
This was referenced Apr 30, 2015
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only parent filters should use bitset filter cache, to avoid memory being wasted.
Closes #10662
Closes #10629