Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommitStats to supply information about the current commit point #10687

Closed
wants to merge 5 commits into from

Conversation

bleskes
Copy link
Contributor

@bleskes bleskes commented Apr 20, 2015

Extends ShardStats with commit specific information. We currently expose commit id, generation and the user data map.

The information is also retrievable via the Rest API by using GET _stats?level=shards

Example output:

"commit": {
     "id": "UEMxOVFVbr/AGlOLg0xytQ==",
     "generation": 3,
     "user_data": {
        "translog_id": "4"
     }
}

… point

Extends ShardStats with commit specific information. We currently expose commit id, generation and the user data map.

The information is also retrievable via the Rest API by using `GET _stats?level=shards`
@brwe
Copy link
Contributor

brwe commented Apr 21, 2015

+1

@@ -70,14 +80,23 @@ public static ShardStats readShardStats(StreamInput in) throws IOException {
public void readFrom(StreamInput in) throws IOException {
super.readFrom(in);
shardRouting = readShardRoutingEntry(in);
stats = CommonStats.readCommonStats(in);
commonStats = CommonStats.readCommonStats(in);
if (in.readBoolean()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use readOptionalStreamable here?

@s1monw
Copy link
Contributor

s1monw commented Apr 21, 2015

left some minor comments! thanks boaz

@s1monw s1monw self-assigned this Apr 21, 2015
@bleskes
Copy link
Contributor Author

bleskes commented Apr 21, 2015

@s1monw thx. pushed another commit

@s1monw
Copy link
Contributor

s1monw commented Apr 22, 2015

LGTM

@bleskes bleskes closed this in a1ba339 Apr 22, 2015
bleskes added a commit that referenced this pull request Apr 22, 2015
… point

Extends ShardStats with commit specific information. We currently expose commit id, generation and the user data map.

The information is also retrievable via the Rest API by using `GET _stats?level=shards`

Closes #10687
@bleskes bleskes deleted the shard_stats_commit_info branch April 22, 2015 07:50
@bleskes bleskes mentioned this pull request May 5, 2015
@bleskes bleskes mentioned this pull request Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants