New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CommitStats to supply information about the current commit point #10687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… point Extends ShardStats with commit specific information. We currently expose commit id, generation and the user data map. The information is also retrievable via the Rest API by using `GET _stats?level=shards`
bleskes
added
>enhancement
v2.0.0-beta1
review
:Data Management/Stats
Statistics tracking and retrieval APIs
v1.6.0
labels
Apr 20, 2015
+1 |
@@ -70,14 +80,23 @@ public static ShardStats readShardStats(StreamInput in) throws IOException { | |||
public void readFrom(StreamInput in) throws IOException { | |||
super.readFrom(in); | |||
shardRouting = readShardRoutingEntry(in); | |||
stats = CommonStats.readCommonStats(in); | |||
commonStats = CommonStats.readCommonStats(in); | |||
if (in.readBoolean()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use readOptionalStreamable here?
left some minor comments! thanks boaz |
@s1monw thx. pushed another commit |
LGTM |
bleskes
added a commit
that referenced
this pull request
Apr 22, 2015
… point Extends ShardStats with commit specific information. We currently expose commit id, generation and the user data map. The information is also retrievable via the Rest API by using `GET _stats?level=shards` Closes #10687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends ShardStats with commit specific information. We currently expose commit id, generation and the user data map.
The information is also retrievable via the Rest API by using
GET _stats?level=shards
Example output: