Add fairness option to KeyedLock.
#10703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaelTadh
added
>enhancement
>test
| @@ -75,6 +77,58 @@ public void checkIfMapEmptyAfterLotsOfAcquireAndReleases() throws InterruptedExc | |||
| } | |||
| } | |||
|
|
|||
| public void checkIfFairLockingWorks() throws InterruptedException { | |||
There was a problem hiding this comment.
not sure what this test tests to be honest but we only pass the param on so no need to really test it. the randomization up there is fine.
|
it looks ok to me but may I ask what triggered this change? |
|
I have a use case for guaranteed order of execution.I'm seeing this test intermittently fail on my build so I'm investigating. |
|
ok I see - please remove this test though we are not testing JDK functionality - the randomization is fine |
|
Can I merge this to 1.x and 1.5? |
GaelTadh
force-pushed
the
enhancment/add_fair_keyedlock
branch
from
8045210
to
8bd1585
Compare
s1monw
added
v2.0.0-beta1
v1.6.0
and removed
>test
|
please squash and push to all relevant branches. 1.5 is bugfix only so please only to 1.x and master |
|
@GaelTadh ping |
GaelTadh
force-pushed
the
enhancment/add_fair_keyedlock
branch
from
38c8766
to
3ad279b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability of a
KeyedLockto befairthis means that threads will aquire the lock in the order they ask for it.Also add a test to ensure the fairness parameter is obeyed.