Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate + Remove More Like This API #10736

Closed
kimchy opened this issue Apr 22, 2015 · 3 comments
Closed

Deprecate + Remove More Like This API #10736

kimchy opened this issue Apr 22, 2015 · 3 comments

Comments

@kimchy
Copy link
Member

kimchy commented Apr 22, 2015

This API always caused more pain then use based on my experience. It tries to help out, and automatically fetch the fields from a doc and build a search request with MLT query in it, but almost always, the situation is more complicated than that (more complex search request, munging the source, no source / stored fields, ...), and the API ends up being misleading.

I think with the MLT query we have the right foundation for (certain type of) more like this functionality. And the user can "get" a document and more easily decide (with the use case in mind) how to build the best search request (which include the MLT query).

Also, I haven't seen in practice many users using the MLT API itself, and the ones I helped, we almost always ended up going for "get" + MLT Query for the flexibility it has.

So, I suggest we deprecate it in 1.6, and remove it in 2.0, thoughts?

@s1monw
Copy link
Contributor

s1monw commented Apr 22, 2015

So, I suggest we deprecate it in 1.6, and remove it in 2.0, thoughts?

+1

@clintongormley
Copy link

+1

@alexksikes
Copy link
Contributor

+1 I agree the MLT API is cumbersome and should be replaced with the query. However, the API is still more efficient because the document is fetched only once, and not on every shard. As soon as we have #10217 in place we can fully remove it. +1 to deprecate it in 1.6.

@alexksikes alexksikes self-assigned this May 5, 2015
alexksikes added a commit that referenced this issue May 6, 2015
Deprecates the More Like This API until it gets removed in 2.0. Users are
encouraged to use the More Like This query.

Relates #10736
Closes #10982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants