Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete expand_wildcards_open and expand_wildcards_close options #10744

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Apr 23, 2015

In #6097 we made snapshot/restore index option consistent with other API. Now we can remove old style options from master.

Closes #10743

@imotov imotov added >breaking v2.0.0-beta1 review :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Apr 23, 2015
@javanna
Copy link
Member

javanna commented Apr 23, 2015

LGTM can you add a small description of this to the migrate guide please?

…ldcards_close options

In elastic#6097 we made snapshot/restore index option consistent with other API. Now we can remove old style options from master.

Closes elastic#10743
@imotov imotov force-pushed the issue-10743-remove-obsolete-expand-wildcards-options branch from 0520211 to 60721b2 Compare April 23, 2015 19:12
@imotov imotov merged commit 60721b2 into elastic:master Apr 23, 2015
@kevinkluge kevinkluge removed the review label Apr 23, 2015
@imotov
Copy link
Contributor Author

imotov commented Apr 23, 2015

@javanna I added the note to the list of breaking changes and pushed it to master. Thanks for the review!

@clintongormley clintongormley changed the title Snapshot/Restore: remove obsolete expand_wildcards_open and expand_wild... Remove obsolete expand_wildcards_open and expand_wildcards_close options Jun 6, 2015
imotov added a commit to imotov/elasticsearch that referenced this pull request Sep 11, 2015
Fixes an issue introduced in elastic#10744 as a result of which the restore request stopped accepting indices options such as ignore_unavailable.

Fixes elastic#13335
imotov added a commit that referenced this pull request Sep 11, 2015
Fixes an issue introduced in #10744 as a result of which the restore request stopped accepting indices options such as ignore_unavailable.

Fixes #13335
imotov added a commit that referenced this pull request Sep 11, 2015
Fixes an issue introduced in #10744 as a result of which the restore request stopped accepting indices options such as ignore_unavailable.

Fixes #13335
imotov added a commit that referenced this pull request Sep 11, 2015
Fixes an issue introduced in #10744 as a result of which the restore request stopped accepting indices options such as ignore_unavailable.

Fixes #13335
@imotov imotov deleted the issue-10743-remove-obsolete-expand-wildcards-options branch May 1, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot/Restore: remove obsolete snapshot/restore expand_wildcards option
3 participants