Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated METADATA cluster block level #10779

Merged
merged 1 commit into from Apr 28, 2015

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Apr 24, 2015

This commit removes the deprecated ClusterBlockLevel.METADATA, replaced in #9203 with METADATA_READ and METADATA_WRITE.

@tlrx tlrx assigned tlrx and javanna and unassigned tlrx Apr 24, 2015
@tlrx
Copy link
Member Author

tlrx commented Apr 24, 2015

@javanna it refers to your comment in #9203. Can you please have a look? thanks a lot!

}
return id();
}

static EnumSet<ClusterBlockLevel> fromId(int id) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fromId doesn't need to return an EnumSet anymore, we can go back to just ClusterBlockLevel. Thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@javanna
Copy link
Member

javanna commented Apr 28, 2015

left a small comment

@tlrx
Copy link
Member Author

tlrx commented Apr 28, 2015

@javanna I just updated the code following your comment

@javanna
Copy link
Member

javanna commented Apr 28, 2015

LGTM

This commit removes the deprecated ClusterBlockLevel.METADATA, replaced in elastic#9203 with METADATA_READ and METADATA_WRITE.
@tlrx tlrx force-pushed the remove-deprecated-metadata-block-level branch from 46779d2 to 2ce0ea1 Compare April 28, 2015 08:25
@tlrx tlrx merged commit 2ce0ea1 into elastic:master Apr 28, 2015
@kevinkluge kevinkluge removed the review label Apr 28, 2015
@tlrx tlrx deleted the remove-deprecated-metadata-block-level branch April 28, 2015 08:27
@clintongormley clintongormley changed the title Internal: Remove deprecated METADATA cluster block level Remove deprecated METADATA cluster block level Jun 8, 2015
@clintongormley clintongormley added :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. and removed :Cluster labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >enhancement v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants