New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate document parsing logic #10802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
added
v2.0.0-beta1
:Search/Mapping
Index mappings, including merging and defining field types
labels
Apr 25, 2015
This is great! LGTM Also +1 on handling multi-fields like copy_to |
rjernst
force-pushed
the
pr/extract-doc-parser
branch
from
April 28, 2015 21:42
f7f180e
to
8eb227c
Compare
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 28, 2015
The code to parse a document was spread across 3 different classes, and depended on traversing the ObjectMapper hiearchy. This change consolidates all the doc parsing code into a new DocumentParser. This should allow adding unit tests (future issue) for document parsing so the logic can be simplified. All code was copied directly for this change with only minor modifications to make it work within the new location. closes elastic#10802
The code to parse a document was spread across 3 different classes, and depended on traversing the ObjectMapper hiearchy. This change consolidates all the doc parsing code into a new DocumentParser. This should allow adding unit tests (future issue) for document parsing so the logic can be simplified. All code was copied directly for this change with only minor modifications to make it work within the new location. closes elastic#10802
rjernst
force-pushed
the
pr/extract-doc-parser
branch
from
April 28, 2015 21:52
8eb227c
to
99584de
Compare
clintongormley
changed the title
Mappings: Consolidate document parsing logic
Consolidate document parsing logic
Jun 8, 2015
brwe
added a commit
to brwe/elasticsearch
that referenced
this pull request
Dec 3, 2015
Copy to within multi field is ignored from 2.0 on, see elastic#10802. Instead of just ignoring it, we should throw an exception if this is found in the mapping when a mapping is added. For already existing indices we should at least log a warning. related to elastic#14946
brwe
added a commit
that referenced
this pull request
Dec 8, 2015
throw exception if a copy_to is within a multi field Copy to within multi field is ignored from 2.0 on, see #10802. Instead of just ignoring it, we should throw an exception if this is found in the mapping when a mapping is added. For already existing indices we should at least log a warning. related to #14946
brwe
added a commit
that referenced
this pull request
Dec 8, 2015
throw exception if a copy_to is within a multi field Copy to within multi field is ignored from 2.0 on, see #10802. Instead of just ignoring it, we should throw an exception if this is found in the mapping when a mapping is added. For already existing indices we should at least log a warning. related to #14946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>enhancement
:Search/Mapping
Index mappings, including merging and defining field types
v2.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to parse a document was spread across 3 different classes,
and depended on traversing the ObjectMapper hiearchy. This change
consolidates all the doc parsing code into a new DocumentParser.
This should allow adding unit tests (future issue) for document
parsing so the logic can be simplified. All code was copied
directly for this change with only minor modifications to make
it work within the new location.