Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTL deletion failures are not logged #11019

Closed
jaymode opened this issue May 6, 2015 · 0 comments · Fixed by #11302
Closed

TTL deletion failures are not logged #11019

jaymode opened this issue May 6, 2015 · 0 comments · Fixed by #11302
Assignees
Labels
>bug :Core/Infra/Logging Log management and logging utilities >enhancement

Comments

@jaymode
Copy link
Member

jaymode commented May 6, 2015

The IndicesTTLService uses a bulk request to perform the deletions of expired documents. Sometimes these deletions could fail, but the service does not log or provide any indication that the deletions are failing.

The onResponse method could check to see if the response had any failures and if so log the failures with the details. Additionally, the onFailure method looks like it will just swallow the Throwable that caused the failure.

@jaymode jaymode added the >bug label May 6, 2015
@clintongormley clintongormley added discuss >enhancement help wanted adoptme :Core/Infra/Logging Log management and logging utilities and removed discuss labels May 7, 2015
@jpountz jpountz removed the help wanted adoptme label May 22, 2015
spinscale added a commit to spinscale/elasticsearch that referenced this issue May 22, 2015
In order to get some information if the TTL purger thread could
successfully delete all documents per bulk exection, this commit
adds some logging. TRACE level logging will potentially contain
a lot of information about all the bulk failures.

Closes elastic#11019
spinscale added a commit to spinscale/elasticsearch that referenced this issue May 22, 2015
In order to get some information if the TTL purger thread could
successfully delete all documents per bulk exection, this commit
adds some logging. TRACE level logging will potentially contain
a lot of information about all the bulk failures.

Closes elastic#11019
spinscale added a commit to spinscale/elasticsearch that referenced this issue May 22, 2015
In order to get some information if the TTL purger thread could
successfully delete all documents per bulk exection, this commit
adds some logging. TRACE level logging will potentially contain
a lot of information about all the bulk failures.

Closes elastic#11019
spinscale added a commit that referenced this issue May 22, 2015
In order to get some information if the TTL purger thread could
successfully delete all documents per bulk exection, this commit
adds some logging. TRACE level logging will potentially contain
a lot of information about all the bulk failures.

Closes #11019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Logging Log management and logging utilities >enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants