Deprecate the top_children query
#11022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
changed the title
top_children queryin favour of the `has_chi…top_children query
martijnvg
force-pushed
the
top_children/deprecation
branch
from
97a9faf
to
d44a5f4
Compare
|
LGTM |
|
Do we want to have it removed in 2.0 or only deprecated? |
|
@jpountz My plan was to remove |
|
Awesome :) |
martijnvg
force-pushed
the
top_children/deprecation
branch
from
d44a5f4
to
f7c2945
Compare
clintongormley
changed the title
top_children querytop_children query
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
top_childrenquery in favour of thehas_childquery.The
top_childrenquery isn't always faster than thehas_childquery and thetop_childrenquery is often inaccurate. The total hits and any aggregations in the same search request will likely be off. Thehas_childquery performance has improved over time and will improve more when #6511 lands.