Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove percent_terms_to_match #11030

Closed
wants to merge 1 commit into from
Closed

Remove percent_terms_to_match #11030

wants to merge 1 commit into from

Conversation

alexksikes
Copy link
Contributor

Users should use minimum_should_match instead.

@alexksikes
More Like This: remove percent_terms_to_match
0dc4f84 
Users should use minimum_should_match instead.
@jpountz
Copy link
Contributor

jpountz commented May 7, 2015

LGTM

@alexksikes alexksikes closed this in 4787cf7 May 7, 2015
@kevinkluge kevinkluge removed the review label May 7, 2015
@alexksikes alexksikes deleted the remove/mlt-percent-terms-to-match branch May 7, 2015 12:23
@clintongormley clintongormley changed the title More Like This: remove percent_terms_to_match Remove percent_terms_to_match Jun 6, 2015
wmfgerrit pushed a commit to wikimedia/mediawiki-extensions-CirrusSearch that referenced this pull request May 4, 2016
@ebernhardson @nomoa
MoreLikeThis percent_terms_to_match -> minimum_should_match
0b811fd 
The percent_terms_to_match field has been removed.
elastic/elasticsearch#11030

Additionally while the docs all show putting the index and page
parameters into the "like" field, since we are specifying them in the
URL we should not provide them here. Providing them twice causes
elasticsearch to return no results (maybe a bug in elasticsearch?).

Bug: T133752
Depends-On: I53617b40275a6fd1a87832a33b5b86e19ad27be0
Change-Id: I84785150dd71fb584e8af5c0c95c0e3b79d4e025
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :More Like This labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>breaking :Search/Search Search-related issues that do not fall into other categories v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexksikes @jpountz @clintongormley @kevinkluge