ThreadPool: make sure no leaking threads are left behind in case of initialization failure #11061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it, LGTM |
|
|
||
| TimeValue estimatedTimeInterval = settings.getAsTime("threadpool.estimated_time_interval", TimeValue.timeValueMillis(200)); | ||
| this.estimatedTimeThread = new EstimatedTimeThread(EsExecutors.threadName(settings, "[timer]"), estimatedTimeInterval.millis()); | ||
| this.estimatedTimeThread.start(); | ||
| } | ||
|
|
||
| public void setNodeSettingsService(NodeSettingsService nodeSettingsService) { | ||
| nodeSettingsService.addListener(new ApplySettings()); |
There was a problem hiding this comment.
Should we add some safety that this method is called only once?
|
Left some suggestions but I like the change too! |
|
@jpountz I pushed some changes. Could you take another look? Thanks! |
| @@ -91,13 +91,14 @@ | |||
|
|
|||
| private final EstimatedTimeThread estimatedTimeThread; | |||
|
|
|||
| private volatile boolean settingsListenerIsSet = false; | |||
There was a problem hiding this comment.
I don't think we need the volatile here?
|
LGTM, only one minor comment |
…nitialization failure Our ThreadPool constructor creates a couple of threads (scheduler and timer) which might not get shut down if the initialization of a node fails. A guice error might occur for example, which causes the InternalNode constructor to throw an exception. In this case the two threads are left behind, which is not a big problem when running es standalone as the error will be intercepted and the jvm will be stopped as a whole. It can become more of a problem though when running es in embedded mode, as we'll end up with lingering threads or testing an handling of initialization failures. Closes elastic#9107
imotov
force-pushed
the
issue-9107-move-thread-pool-initialization-out-of-guice
branch
from
389382f
to
573caca
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our ThreadPool constructor creates a couple of threads (scheduler and timer) which might not get shut down if the initialization of a node fails. A guice error might occur for example, which causes the InternalNode constructor to throw an exception. In this case the two threads are left behind, which is not a big problem when running es standalone as the error will be intercepted and the jvm will be stopped as a whole. It can become more of a problem though when running es in embedded mode, as we'll end up with lingering threads or testing an handling of initialization failures.
Closes #9107