Don't throw an exception if repositories are unregistered with *
#11113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
>enhancement
v2.0.0-beta1
review
:Distributed/Snapshot/Restore
|
@imotov can you take a look at this? |
| @@ -190,6 +190,9 @@ public ClusterState execute(ClusterState currentState) { | |||
| mdBuilder.putCustom(RepositoriesMetaData.TYPE, repositories); | |||
| return ClusterState.builder(currentState).metaData(mdBuilder).build(); | |||
| } | |||
| if (Regex.isMatchAllPattern(request.name)) { // we use a wildcard so we don't barf if it's not present. | |||
There was a problem hiding this comment.
This code will be never executed. I think you meant to put it after the if statement where we check if we have any repositories registered.
|
pushed a new commit |
|
LGTM |
Today we barf if repositories are unregistered with a `*` pattern. This happens on almost every test and adds weird log messages. I dont' think we should barf in that case. Closes elastic#11113
s1monw
force-pushed
the
delete_wildcard_repository
branch
from
9ae8427
to
869baee
Compare
s1monw
added a commit
that referenced
this pull request
May 13, 2015
Today we barf if repositories are unregistered with a `*` pattern. This happens on almost every test and adds weird log messages. I dont' think we should barf in that case. Closes #11113
clintongormley
changed the title
*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we barf if repositories are unregistered with a
*pattern. Thishappens on almost every test and adds weird log messages. I dont' think
we should barf in that case.