Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed ignore_like to unlike #11117

Closed
wants to merge 1 commit into from

Conversation

alexksikes
Copy link
Contributor

This changes the parameter name ignore_like to the more user friendly name
unlike. This later feature generates a query from the terms in A but not
from the terms in B. This translates to a result set which is like A but
unlike B. We could have further negatively boosted any documents that have
some B, but these documents already do not receive any contribution from
having B, and would therefore negatively compete with documents having A.

This changes the parameter name `ignore_like` to the more user friendly name
`unlike`. This later feature generates a query from the terms in `A` but not
from the terms in `B`. This translates to a result set which is like `A` but
unlike `B`. We could have further negatively boosted any documents that have
some `B`, but these documents already do not receive any contribution from
having `B`, and would therefore negatively compete with documents having `A`.
@clintongormley clintongormley changed the title More Like This: renamed ignore_like to unlike Renamed ignore_like to unlike Jun 7, 2015
@jpountz
Copy link
Contributor

jpountz commented Jun 17, 2015

I'm a bit uncomfortable with this renaming given that ignore_like better describes the current behaviour, given that we just ignore the negative terms? unlike would feel to me like we give negative boosts to documents that contain the negative terms, which is not what we do?

@alexksikes
Copy link
Contributor Author

So suppose we have like A but unlike B type of query. Under the hood we form a query made of the terms in A - B. So we are interested about the documents (vectors) near the vector A - B, which corresponds to a result set in which the user gets documents which are like A but unlike B. Sure some documents could have some terms in B but they would not contribute to the score of the document, only the terms in A - B contribute to such a score. Also if we wanted to further negatively boost the terms in B, the user could always use boosting queries. I think that unlike reads much better than ignore_like from user perspective.

@clintongormley
Copy link

It's tricky. I kinda read ignore_like as a stronger promise: don't return anything like FOO. unlike feels a bit weaker, so I think I'd stick with unlike

@jpountz
Copy link
Contributor

jpountz commented Jun 17, 2015

OK, let's merge then!

@alexksikes alexksikes deleted the enhancement/mlt-unlike branch June 17, 2015 22:32
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :More Like This labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants