Remove filter from PhraseSuggester collate #11195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollate. Only `query` can be used for collation. Internally, a collate query is executed as an exists query. So specifying a filter does not have any benefits.
areek
added
>enhancement
v2.0.0-beta1
review
:Search/Suggesters
|
@areek let's deprecate this in 1.6 and push this as is to 2.0 ok? LGTM though |
|
committed to 2.0 (fb8cd53) |
areek
added a commit
to areek/elasticsearch
that referenced
this pull request
Jun 2, 2015
Collate filter option is removed in v2.0.0, use collate query for collation in PhraseSuggester. see elastic#11195
areek
added a commit
that referenced
this pull request
Jun 2, 2015
DOCS: Deprecate filter option in PhraseSuggester collate Collate filter option is removed in v2.0.0, use collate query for collation in PhraseSuggester. see #11195
olivere
added a commit
to olivere/elastic
that referenced
this pull request
Jun 24, 2016
The `filter` has been removed from 2.0. See elastic/elasticsearch#11195. See #299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the ability to use
filterfor PhraseSuggester collate.Only
querycan be used for collation.Internally, a collate query is executed as an exists query. So specifying a
filter does not have any benefits.