detect_noop now understands null as a valid value
#11210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| modified = true; | ||
| continue; | ||
| } | ||
| modified = !old.equals(changesEntry.getValue()); | ||
| modified = old == null ? changesEntry.getValue() != null : !old.equals(changesEntry.getValue()); |
There was a problem hiding this comment.
maybe this could be simplified to modified = !java.util.Objects.equal(old, changesEntry.getValue())?
There was a problem hiding this comment.
Yeah. I forget about that one.
clintongormley
added
>bug
review
:Distributed/CRUD
|
This looks good to me, I'll merge it tomorrow if nobody else has objections. |
|
Updated based on your comment. I can squash the changes if you want. |
|
That would be great. :-) |
If the source contrains a null value for a field then detect_noop should consider setting it to null again to be a noop. Closes elastic#11208
|
Squashed. |
jpountz
added a commit
that referenced
this pull request
May 19, 2015
detect_noop now understands null as a valid value
clintongormley
changed the title
detect_noop now understands null as a valid value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the source contrains a null value for a field then detect_noop should
consider setting it to null again to be a noop.
Closes #11208