Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile name to TransportChannel #11261

Merged
merged 1 commit into from May 21, 2015
Merged

Conversation

jaymode
Copy link
Member

@jaymode jaymode commented May 20, 2015

Today, only the NettyTransportChannel implements the getProfileName method
and the other channel implementations do not. The profile name is useful for some
plugins to perform custom actions based on the name. Rather than checking the
type of the channel, it makes sense to always expose the profile name.

For DirectResponseChannels we use a name that cannot be used in the settings
to define another profile with that name. For LocalTransportChannel we use the
same name as the default profile.

Closes #10483

@jaymode jaymode added >enhancement v2.0.0-beta1 review :Distributed/Network Http and internode communication implementations labels May 20, 2015
@jaymode
Copy link
Member Author

jaymode commented May 20, 2015

@spinscale can you review?

@spinscale
Copy link
Contributor

LGTM with the exception of the naming. The DirectChannel is named ".local" whereas the LocalChannel is named "default" - might be confusing?

@jaymode
Copy link
Member Author

jaymode commented May 21, 2015

What do you think about .direct for DirectChannel? The LocalTransportChannel profile should stay as default IMO because it is used with the LocalTransport and there is only one profile in that case.

@spinscale
Copy link
Contributor

@jaymode +1 for that

Today, only the NettyTransportChannel implements the getProfileName method
and the other channel implementations do not. The profile name is useful for some
plugins to perform custom actions based on the name. Rather than checking the
type of the channel, it makes sense to always expose the profile name.

For DirectResponseChannels we use a name that cannot be used in the settings
to define another profile with that name. For LocalTransportChannel we use the
same name as the default profile.

Closes elastic#10483
@jaymode jaymode merged commit 8060cd0 into elastic:master May 21, 2015
@kevinkluge kevinkluge removed the review label May 21, 2015
@clintongormley clintongormley changed the title add profile name to TransportChannel Add profile name to TransportChannel Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Network Http and internode communication implementations >enhancement v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add profile name to TransportChannel
3 participants