Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FSRepository location configuration #11284

Merged

Conversation

imotov
Copy link
Contributor

@imotov imotov commented May 21, 2015

Locations of file system repositories has to be now registered using path.repo setting. This is back port of a similar 2.0 feature into 1.6 branch.

Closes #11068

@imotov imotov added >breaking :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v1.6.0 labels May 21, 2015
@imotov
Copy link
Contributor Author

imotov commented May 21, 2015

I am unsure about proper location and handling of test file system repositories in InternalTestCluster. So, if somebody has a better idea where to put it, please comment.

@dakrone
Copy link
Member

dakrone commented May 28, 2015

LGTM, I think the test file system stuff works fine in InternalTestCluster

@imotov imotov force-pushed the issue-11068-fix-fs-repo-location-configuration-1.x branch from 84af88f to f5cfb2a Compare May 29, 2015 05:43
@imotov imotov merged commit f5cfb2a into elastic:1.x May 29, 2015
@imotov imotov removed the review label May 29, 2015
@clintongormley clintongormley changed the title Snapshot/Restore: fix FSRepository location configuration Fix FSRepository location configuration Jun 9, 2015
@jettro
Copy link

jettro commented Jun 16, 2015

Can someone explain why this change was required? I am curious why I have to configure the possible path. It breaks my current implementations and I would like to understand why.

@imotov
Copy link
Contributor Author

imotov commented Jun 16, 2015

@jettro it was needed to make default elasticsearch installation more secure. You can find more information in the 1.6.0 release blog post. Please note that the paths in repo.path have to match the prefix of your repository location. You don't have to specify there the whole path. It can be just shared filesystem mount point if you create multiple repositories. Alternatively, if your elasticsearch installation is secure and only authorized users can register repositories, you can essentially turn off the repository sandboxing by simply setting repo.path to "/" in the elasticsearch configuration file. This will get you back to the pre-1.6.0 behavior where repositories can be created anywhere on the local file system.

@rikkit
Copy link

rikkit commented Aug 4, 2015

@imotov

Alternatively, if your elasticsearch installation is secure and only authorized users can register repositories, you can essentially turn off the repository sandboxing by simply setting repo.path to "/" in the elasticsearch configuration file. This will get you back to the pre-1.6.0 behavior where repositories can be created anywhere on the local file system.

This is not true. 😕 The previous behaviour was any old path could be used... "/" restricts to the local system. I want to be able to restore snapshots from arbitrary network shares for my development cluster. There doesn't seem to be a way of configuring that behaviour.

edit: opened an issue at #12665

@imotov imotov deleted the issue-11068-fix-fs-repo-location-configuration-1.x branch May 1, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v1.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants