Display low disk watermark to be consistent with documentation #11313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintongormley
added
>enhancement
review
:Core/Infra/Logging
clintongormley
changed the title
|
@dakrone please could you review |
| @@ -413,7 +426,7 @@ public Decision canAllocate(ShardRouting shardRouting, RoutingNode node, Routing | |||
| Strings.format1Decimals(freeDiskPercentage, "%"), node.nodeId()); | |||
| } | |||
| return allocation.decision(Decision.NO, NAME, "less than required [%s%%] free disk on node, free: [%s%%]", | |||
There was a problem hiding this comment.
I believe this message needs to be changed now, since the first value is the "used" value now
|
@mkis- I left one comment, other than that this looks good to me, let me know when that is fixed and I will merge it in! |
|
@dakrone Thank you for your feedback. I changed the phrasing of messages around it for consistency. |
| DiskThresholdDecider.this.freeBytesThresholdLow, usage); | ||
| } | ||
|
|
||
| // Check percentage disk values | ||
| if (usage.getFreeDiskAsPercentage() < DiskThresholdDecider.this.freeDiskThresholdHigh) { | ||
| logger.warn("high disk watermark [{} free] exceeded on {}, shards will be relocated away from this node", | ||
| logger.warn("high disk watermark [{}] exceeded on {}, shards will be relocated away from this node", | ||
| Strings.format1Decimals(DiskThresholdDecider.this.freeDiskThresholdHigh, "%"), usage); |
There was a problem hiding this comment.
I believe this should be 100.0 - DiskThresholdDecider.this.freeDiskThresholdHigh, just like below, right?
|
@mkis- left one more comment, looks like a missed |
documentaiton Change log entries, add convenience methods, unit tests Correct allocation decision messages to display used space Missed a word Correct displayed threshold value
|
@dakrone Made the change and squashed the commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempted fix for Issue #10588. I have added altered log entries, so that messages involving disk usage percentages display used disk percentages, rather than free disk percentages.
Closes #10588