Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting: keep track of the original query only in HighlighterContext #11317

Merged

Conversation

javanna
Copy link
Member

@javanna javanna commented May 23, 2015

We used to keep track of the rewritten query in the highlighter context to support custom rewriting done by our own postings highlighter fork. Now that we rely on lucene implementation, no rewrite happens, we can simply keep track of the original query and simplify code around it.

@jpountz
Copy link
Contributor

jpountz commented May 23, 2015

LGTM, thanks for cleaning things up!

@javanna javanna removed the review label May 26, 2015
…text

We used to keep track of the rewritten query in the highlighter context to support custom rewriting done by our own postings highlighter fork. Now that we rely on lucene implementation, no rewrite happens, we can simply keep track of the original query and simplify code around it.

Closes elastic#11317
@javanna javanna force-pushed the enhancement/simplify_highlight_query branch from 673e208 to 543f572 Compare May 26, 2015 10:47
@javanna javanna merged commit 543f572 into elastic:master May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants