Ignore 3x segment upgrade if unneeded #11383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s1monw pushed another commit making this encapsulated into the InternalEngine |
| @@ -118,7 +119,24 @@ public InternalEngine(EngineConfig engineConfig) throws EngineException { | |||
| boolean success = false; | |||
| try { | |||
| try { | |||
| upgrade3xSegments(store); | |||
| String version = engineConfig.getIndexSettings().get("index.version.created"); | |||
| boolean autoUpgrade = true; | |||
There was a problem hiding this comment.
can you use Version#indexCreated(Settings) here instead?
|
left one comment otherwise LGTM |
If the index was created with 0.90.x or later, skip the check for 3x segments, since Lucene 4.x was used for those versions. This helps in particular with sharedfs recoveries, where the check for upgrading segments can cause FS race conditions.
dakrone
force-pushed
the
ignore-segment-upgrade
branch
from
e154495
to
1ed7bfb
Compare
|
@s1monw Are we saying that v1.6 will not be compatible with indices created before v0.19? |
|
@s1monw I see. Thanks! It looks like this is going to be a problem only in master, which cannot open these files anyway. It might be a good idea to improve the error message though. I will take a look. |
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the index was created with 0.90.x or later, skip the check for 3x
segments, since Lucene 4.x was used for those versions.
This helps in particular with sharedfs recoveries, where the check for
upgrading segments can cause FS race conditions.
(Note, this is for 1.x only)
Slightly related to #11361