Better exception if array passed to term query.
#11384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, signed yesterday just after the PR, do I need to do anything else to update the status? |
|
Yes - I see the signature, it uses a different email address. thanks @spyk |
|
Thanks @spyk merged! Also marking as breaking as people who might be sending an array will get errors back now. |
|
I think this is a bug fix rather than a breaking enhancement - relabelled as such. |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check that explicitly throws an exception in case of an array, and a small unit test to verify it.
By the way, the particular test case would not throw an exception before the fix, but would actually only evaluate the last value of the array, so the behavior was indeed erratic in case of an array.
Closes #11246.