Consolidate directory lock obtain code #11390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * This method uses the {@link IndexWriterConfig#getDefaultWriteLockTimeout()} as the lock timeout. | ||
| */ | ||
| public static Lock acquireWriteLock(Directory directory) throws IOException { | ||
| return acuquireLock(directory, IndexWriter.WRITE_LOCK_NAME, IndexWriterConfig.getDefaultWriteLockTimeout()); |
|
looks good. it simplifies callers usage of locks. but this wont' avoid any problems from LUCENE-6507, its just a good cleanup. |
The Directory#makeLock API is trappy and can easily lead to unexpected lock release if native locks are used. see LUCENE-6507 for details. This commit consolidates the lock lock into one place and only returns the lock instance if we actually acquired it.
clintongormley
added
the
:Distributed/Store
clintongormley
added
:Distributed/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Directory#makeLock API is trappy and can easily lead to unexpected
lock release if native locks are used. see LUCENE-6507 for details.
This commit consolidates the lock lock into one place and only returns
the lock instance if we actually acquired it.