Fall back to reading SegmentInfos from Store if reading from commit fails #11403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related CI failure: http://build-us-00.elastic.co/job/es_core_master_centos/4928/consoleFull |
| IndexSearcher searcher = sm.acquire(); | ||
| try { | ||
| IndexCommit latestCommit = ((DirectoryReader) searcher.getIndexReader()).getIndexCommit(); | ||
| return Lucene.readSegmentInfos(latestCommit); | ||
| } catch (IOException e) { | ||
| // Fall back to reading from the store if reading from the commit fails | ||
| return store.readLastCommittedSegmentsInfo(); |
There was a problem hiding this comment.
can you wrap this in try/catch and add the original exception as suppressed if readLastCommittedSegmentsInfo fails?
|
left one comment otherwise LGTM |
dakrone
force-pushed
the
si-reading-fallback
branch
from
c9eb596
to
4271ad6
Compare
fails In the event that reading from the latest commit fails, we should fall back to reading from the `Store` using the traditional `Directory.listAll()` Related to elastic#11361
dakrone
force-pushed
the
si-reading-fallback
branch
from
4271ad6
to
790baed
Compare
clintongormley
added
>enhancement
:Distributed/Store
clintongormley
added
:Distributed/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that reading from the latest commit fails, we should fall
back to reading from the
Storeusing the traditionalDirectory.listAll()Related to #11361