Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MapperException detection during translog ops replay #11583

Merged
merged 1 commit into from Jun 10, 2015

Conversation

bleskes
Copy link
Contributor

@bleskes bleskes commented Jun 10, 2015

The current ExceptionsHelper.unwrapCause(exception) requires the incoming exception to support ElasticsearchWrapperException , which TranslogRecoveryPerformer.BatchOperationException doesn't implement. I opted for a more generic solution

Example failure: http://build-us-00.elastic.co/job/es_g1gc_master_metal/8534/testReport/junit/org.elasticsearch.recovery/RelocationTests/testRelocationWhileRefreshing/

See #11363

The current ExceptionsHelper.unwrapCause(exception) requires the incoming exception to support ElasticsearchWrapperException , which TranslogRecoveryPerformer.BatchOperationException doesn't implement. I opted for a more generic solution
@bleskes bleskes added >bug v2.0.0-beta1 :Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. labels Jun 10, 2015
@s1monw
Copy link
Contributor

s1monw commented Jun 10, 2015

LGTM

bleskes added a commit that referenced this pull request Jun 10, 2015
Recovery: Fix MapperException detection during translog ops replay
@bleskes bleskes merged commit 650950c into elastic:master Jun 10, 2015
@bleskes bleskes deleted the mapper_exception_unwrap branch June 10, 2015 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants