Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut exists and missing queries when no types/docs exist #11586

Merged
merged 1 commit into from Jun 10, 2015

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Jun 10, 2015

There used to be a null check for _field_names mapper not existing. This
was recently removed. However, there is a corner case when the mapper
may be missing: when no types or docs exist at all in the index.

This change adds back a null check and just returns no docs.

There used to be a null check for _field_names mapper not existing. This
was recently removed. However, there is a corner case when the mapper
may be missing: when no types or docs exist at all in the index.

This change adds back a null check and just returns no docs.
@rjernst rjernst added v2.0.0-beta1 :Search/Mapping Index mappings, including merging and defining field types labels Jun 10, 2015
@s1monw
Copy link
Contributor

s1monw commented Jun 10, 2015

LGTM

rjernst added a commit that referenced this pull request Jun 10, 2015
Mappings: Shortcut exists and missing queries when no types/docs exist
@rjernst rjernst merged commit d372bf7 into elastic:master Jun 10, 2015
@rjernst rjernst deleted the fix/field-names-null branch June 10, 2015 21:58
@clintongormley clintongormley changed the title Mappings: Shortcut exists and missing queries when no types/docs exist Shortcut exists and missing queries when no types/docs exist Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Mapping Index mappings, including merging and defining field types v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants