Upgrade to Lucene 5.2.1. #11662
Merged
Upgrade to Lucene 5.2.1. #11662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks related to LUCENE-6523 but I'm not sure yet if this is the expected behaviour or if it hides a bug. |
It is unnecessary to test features we are not using.
|
Since we don't use prepareCommit in Elasticsearch, I removed this test and opened https://issues.apache.org/jira/browse/LUCENE-6565. I think it's ready now. |
|
LGTM |
clintongormley
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have one remaining nocommit to fix in SimpleLuceneTests because of DirectoryReader.openIfChanged returning a non-null reader after IndexWriter.prepareCommit has been called. I'll dig.