Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependencies for RPM/DEB packages #11664

Merged
merged 1 commit into from Jun 23, 2015

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Jun 15, 2015

Since elasticsearch doesn't shade artifacts anymore (see #11522), the dependencies list for RPM/DEB must be updated. In this commit, we package all maven libs by default except the generated -shaded/-tests/-test-cours JARs and slf4j-api (marked as optionnal).

@tlrx tlrx added v2.0.0-beta1 review :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts labels Jun 15, 2015
@dadoonet
Copy link
Member

I did not try to run it but it looks good to me.

That said, I had a discussion with @rmuir about how we should declare what we want to embed in plugins. The conclusion was that we should somehow declare explicitly what we want to add instead of excluding... See discussion here: #11647 (comment)

So may be we should be consistent here with that position. WDYT?

@clintongormley clintongormley changed the title [Packaging] Fix missing dependencies for RPM/DEB packages Fix missing dependencies for RPM/DEB packages Jun 15, 2015
@tlrx
Copy link
Member Author

tlrx commented Jun 15, 2015

@dadoonet thanks! I think this case is different from plugins. The deb/rpm is just another way to package elasticsearch: there's no additional code or dependencies needed and there won't be any conflicting lib like in plugins. Here we need to be sure to include everything, so excluding only what we don't need makes sense to me.

@tlrx tlrx added >bug and removed >enhancement labels Jun 15, 2015
@spinscale
Copy link
Contributor

@tlrx LGTM

@dadoonet agreeing with @tlrx here, I think we can keep the behaviour. We already broke deb/rpm packaging once, by not including ant-lr in rpm/deb and thus having lucene expressions not working.

Since elasticsearch doesn't shade artifacts anymore (see elastic#11522), the dependencies list for RPM/DEB must be updated. Now we package all maven libs by default except the generated -shaded/-tests/-test-cours JARs and slf4j-api (marked as optionnal).
@tlrx tlrx force-pushed the fix-rpm-and-deb-libs-on-master branch from 49e52f5 to 95caa73 Compare June 23, 2015 11:16
@tlrx tlrx merged commit 95caa73 into elastic:master Jun 23, 2015
@kevinkluge kevinkluge removed the review label Jun 23, 2015
@tlrx
Copy link
Member Author

tlrx commented Jun 23, 2015

thanks @spinscale !

@tlrx tlrx deleted the fix-rpm-and-deb-libs-on-master branch June 23, 2015 11:24
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants