Remove non-default fielddata formats. #11669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that doc values are the default for fielddata, specialized in-memory formats are becoming an esoteric option. This commit removes such formats: - `fst` on string fields, - `compressed` on geo points. I also removed documentation and tests that the fielddata cache is shared if you change the format, since this is only true for in-memory fielddata formats (given that for doc values, the caching is done directly in Lucene).
|
nice cleanup, LGTM! |
jpountz
added a commit
that referenced
this pull request
Jun 15, 2015
Remove non-default fielddata formats.
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions-GeoData
that referenced
this pull request
Jul 6, 2016
c.f. elastic/elasticsearch#11669 Change-Id: I058d5bad2d9deeff07e1d08cbd00dbe3d6e8576d
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that doc values are the default for fielddata, specialized in-memory
formats are becoming an esoteric option. This commit removes such formats:
fston string fields,compressedon geo points.I also removed documentation and tests that the fielddata cache is shared if
you change the format, since this is only true for in-memory fielddata formats
(given that for doc values, the caching is done directly in Lucene).
In terms of backward compatibility, IndexFielddataService already falls back to
the default fielddata format in case the configured fielddata format can't be found,
and logs a warning.