jar hell check should fail, if jars require higher java version #11936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note we also have other useful metadata in plugin jars like ES and lucene versions. I want to do that on separate issues. The java version is just the most basic check. |
|
LGTM |
rmuir
added a commit
that referenced
this pull request
Jun 30, 2015
jar hell check should fail, if jars require higher java version
clintongormley
added
>enhancement
:Delivery/Packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could happen e.g. if a plugin requires java 8, but the user is on java 7. Instead of strange classfile format errors, we can try for a nice exception.
In order to be efficient, we just check jar manifest metadata for this, if available. This is nonstandard but e.g. all lucene and ES jars have it.
Otherwise we'd have to do something that would be prohibitively slow (like looking at bytes of classes). So its a best effort.