Aggregations: Makes ValueFormat and ValueFormatter never null #11943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colings86
added
>enhancement
v2.0.0-beta1
review
:Analytics/Aggregations
| @@ -60,7 +60,8 @@ | |||
|
|
|||
| public HistogramAggregator(String name, AggregatorFactories factories, Rounding rounding, InternalOrder order, | |||
| boolean keyed, long minDocCount, @Nullable ExtendedBounds extendedBounds, | |||
| @Nullable ValuesSource.Numeric valuesSource, @Nullable ValueFormatter formatter, | |||
| @Nullable ValuesSource.Numeric valuesSource, | |||
| ValueFormatter formatter, | |||
|
Wonderful! LGTM |
This allows a lot of null checks to be removed where we were always falling back to the ValueFormat.RAW anyway. Now the format is set to ValueFormat.RAW when no alternative is suitable. Closes #10594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a lot of null checks to be removed where we were always falling back to the ValueFormat.RAW anyway. Now the format is set to ValueFormat.RAW when no alternative is suitable.
Closes #10594