Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

really ban exitVM with security policy #11982

Merged
merged 1 commit into from Jul 1, 2015
Merged

Conversation

rmuir
Copy link
Contributor

@rmuir rmuir commented Jul 1, 2015

Today this is implicitly allowed. In tests actually we stop it, because Uwe already fixed this issue in TestSecurityManager. But nothing stops it when you are actually running ES.

See the notes in RuntimePermission[1]:

 Note: The "exitVM.*" permission is automatically granted to all code loaded from 
 the application class path, thus enabling applications to terminate themselves.
  1. http://docs.oracle.com/javase/7/docs/api/java/lang/RuntimePermission.html

@rjernst
Copy link
Member

rjernst commented Jul 1, 2015

LGTM

rmuir added a commit that referenced this pull request Jul 1, 2015
really ban exitVM with security policy
@rmuir rmuir merged commit ce900b4 into elastic:master Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants