Don't require fields in alias filters to exist in the mapping #12150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
changed the title
|
LGTM. Can you add a description to the PR? |
martijnvg
changed the title
martijnvg
added a commit
that referenced
this pull request
Jul 10, 2015
…_parsing Don't require fields in alias filters to exist in the mapping
clintongormley
added
:Data Management/Indices APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before alias filters were parsed at alias creation time. Therefor it was critical that fields used in alias filters exist in the mapping, otherwise the the alias filter wouldn't work correctly.
Now that alias filters are parsed at request time, the restriction that a field needs to exist at alias creation time is no longer valid. This PR removes that restriction.