New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RegexpQueryParser takes a String as value like its Builder #12200
RegexpQueryParser takes a String as value like its Builder #12200
Conversation
don't we want to change the mappers as well to accept a String instead of an Object? |
9d49b75
to
bda8092
Compare
@javanna Thanks for the review. I changed the mapper as well. |
@@ -76,7 +76,7 @@ public Query parse(QueryParseContext parseContext) throws IOException, QueryPars | |||
currentFieldName = parser.currentName(); | |||
} else { | |||
if ("value".equals(currentFieldName)) { | |||
value = parser.objectBytes(); | |||
value = parser.textOrNull(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure whether we want to use text() or textOrNull() here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alex's comment on the prefix query that we need to check for null anyway and can have a better error message this way makes sense to me
looks good, @jpountz can you please have a look too? I had a question above ;) |
LGTM |
Relates #11896