Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_only_nodes preference parsed incorrectly #12460

Closed
wants to merge 2 commits into from
Closed

_only_nodes preference parsed incorrectly #12460

wants to merge 2 commits into from

Conversation

nirmalc
Copy link
Contributor

@nirmalc nirmalc commented Jul 25, 2015

Fix for #12389

@clintongormley clintongormley changed the title Fix for _only_nodes in 1.7 _only_nodes preference parsed incorrectly Jul 27, 2015
@clintongormley clintongormley added >bug review :Search/Search Search-related issues that do not fall into other categories labels Jul 27, 2015
@clintongormley
Copy link

@nirmalc any chance we can have a test for this? If we'd had a test, the bug would have been caught during the backport

thanks

@nirmalc
Copy link
Contributor Author

nirmalc commented Jul 27, 2015

Will try if i can add test to the Preferences class - as of now we dont have tests for any of that , At the minumum - we should be able to add tests for those static methods there.

spinscale pushed a commit that referenced this pull request Jul 28, 2015
@spinscale
Search Preference: Fix for _only_nodes
2fa7404 
The `_only_nodes` preference was not parsed correctly.
This adds the preference, so it gets parsed as lowercase as
well as tests.

Closes #12460
Closes #12389
@clintongormley
Copy link

Merged in 2fa7404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>bug :Search/Search Search-related issues that do not fall into other categories v1.7.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nirmalc @clintongormley