Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin script to allow spaces in ES_HOME #12610

Merged
merged 1 commit into from Aug 4, 2015

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Aug 3, 2015

Fixes ES_HOME with spaces and installing plugins from a local directory
with spaces.

Closes #12504

Fixes ES_HOME with spaces and installing plugins from a local directory
with spaces.

Closes elastic#12504
@nik9000
Copy link
Member Author

nik9000 commented Aug 3, 2015

This is pretty much a clean forward port of #12544. It was difficult to test because the tests require a 2.0 compatible version of watcher which you have to build from source. And to do that you have to be past of the Elastic organization because that is a closed source plugin. That's certainly going to have to change.

Ping @tlrx, @spinscale, and @electrical who looked at the 1.7 version of this.

@electrical
Copy link
Contributor

Looks good to me as far as i can see.

@tlrx
Copy link
Member

tlrx commented Aug 4, 2015

It was difficult to test because the tests require a 2.0 compatible version of watcher which you have to build from source.

Are you talking about the BATS tests? If so, maybe we should move them apart.

@jaymode
Copy link
Member

jaymode commented Aug 4, 2015

LGTM

@nik9000
Copy link
Member Author

nik9000 commented Aug 4, 2015

Are you talking about the BATS tests? If so, maybe we should move them apart.

They already have this problem because the plugin installer tries to fetch watch for 1.7 and can't. Since it isn't making anything worse I'll just merge this as is.

I'll create a followup issues to the bats tests not being consistent.

nik9000 added a commit that referenced this pull request Aug 4, 2015
@nik9000 nik9000 merged commit e8ccdf9 into elastic:master Aug 4, 2015
@clintongormley clintongormley changed the title Plugin script: Fix spaces Fix plugin script to allow spaces in ES_HOME Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants